From e0b71d767efb42be74f543d37539d0b230d18997 Mon Sep 17 00:00:00 2001 From: Enrique Gonzalez Date: Wed, 27 Nov 2024 16:15:38 -0800 Subject: [PATCH 1/2] refactor(search): externalize Algolia search configuration Move hardcoded Algolia credentials (appId, indexName, apiKey) to a centralized searchMetadata configuration object. This change improves maintainability by consolidating search configuration in a dedicated location. --- src/components/search/Search.tsx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/components/search/Search.tsx b/src/components/search/Search.tsx index 2b9cc5913..bf8b962ab 100644 --- a/src/components/search/Search.tsx +++ b/src/components/search/Search.tsx @@ -1,5 +1,5 @@ import { useEffect, useState } from 'react'; - +import { searchMetadata } from '../../data/search'; import { DocSearch } from './docsearch/DocSearch'; import './docsearch/docsearch.css'; @@ -24,11 +24,12 @@ export const Search = () => { }, []); const initialQuery = getInitialQuery(); + const { algoliaConfig } = searchMetadata; return ( ); From 5fc6ca80cabc8cb33f938071e2690dfb5859e7c9 Mon Sep 17 00:00:00 2001 From: Enrique Gonzalez Date: Wed, 27 Nov 2024 16:16:21 -0800 Subject: [PATCH 2/2] feat(search): increase max results per group to 20 in Algolia search Adds maxResultsPerGroup configuration parameter to Algolia search component and sets it to 20 results per group in search metadata configuration. --- src/components/search/Search.tsx | 1 + src/data/search.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/components/search/Search.tsx b/src/components/search/Search.tsx index bf8b962ab..2e6030ffd 100644 --- a/src/components/search/Search.tsx +++ b/src/components/search/Search.tsx @@ -31,6 +31,7 @@ export const Search = () => { indexName={algoliaConfig.indexName} apiKey={algoliaConfig.apiKey} initialQuery={initialQuery} + maxResultsPerGroup={algoliaConfig.maxResultsPerGroup} /> ); }; diff --git a/src/data/search.ts b/src/data/search.ts index 5e65e0fa3..40698c731 100644 --- a/src/data/search.ts +++ b/src/data/search.ts @@ -11,5 +11,6 @@ export const searchMetadata = { // Public API key: it is safe to commit it apiKey: '1b6e51c1d4ef24bef0a5f1ab00dad80a', indexName: 'sourcegraph', + maxResultsPerGroup:20 }, }