Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove sourcegraph.com vanity import path #27
This package is currently accessible via sourcegraph.com/sourcegraph/go-diff but there isn't really a good reason for this, and we no longer serve vanity import paths at e.g. https://sourcegraph.com/sourcegraph/go-diff (the real location is now https://sourcegraph.com/github.com/sourcegraph/go-diff)
This package is in use by the Go build bots, it looks like: https://github.com/golang/build/blob/master/go.mod#L74
Some firewalls block Cloudflare, which Sourcegraph.com is hosted through -- making this package hard to fetch needlessly. Reported on Slack here: https://gophers.slack.com/archives/C9BMAAFFB/p1542362482359900
A PR for this would be very much appreciated :)
Changing the import path of a package has some cost, which should be taken into account when making a decision like this.
Note that the
There are many more of them, including:
I'm not opposed to this per-se, I just think it would be helpful to think about the bigger picture and the long term direction before making a change to a single package. For example, removing the vanity import path for this package but not
Yeah, everything you said is true.
Currently @ Sourcegraph we only use two of the packages you've listed:
My thinking was that the long term goal here would be:
My inclination is that these vanity import paths made sense when
I agree that this would cause an annoyance (need to update the import path) for downstream users of these packages, though. I didn't think that portion through, and I'm not sure the best way to tackle that.
Perhaps what we could do is allow using the package at both locations first, asking users to migrate to github.com, and then enforcing the github.com import with an
That makes sense as a long term vision, thanks for explaining.
A gradual transition like that makes sense, but it's worth noting that it doesn't change the amount of work that needs to be done, it just makes it possible to do that work over a longer period of time without immediate breakage.