Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go-vcs, vcs/hgcmd: update .../sourcegraph/go-diff/diff import path #112

merged 1 commit into from Apr 9, 2019


None yet
2 participants
Copy link

dmitshur commented Apr 6, 2019

It has changed in sourcegraph/go-diff#30.

Updates sourcegraph/go-diff#27

/cc @sqs

You should probably not merge this before sourcegraph/go-diff#33 is resolved, otherwise this PR will break this project in module mode. Edit: Issue sourcegraph/go-diff#33 has been resolved, so this is safe to merge now.


This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Apr 8, 2019

Friendly ping @sqs.

This should help anyone who depends on go-vcs, directly or indirectly, similarly to what was mentioned in sourcegraph/go-diff#33 (comment). Please let me know if there any concerns.


slimsag approved these changes Apr 9, 2019

Copy link

slimsag left a comment

LGTM . Thanks Dmitri! :)

@slimsag slimsag merged commit d784c95 into sourcegraph:master Apr 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@dmitshur dmitshur deleted the shurcooL:diff-path branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.