This repository was archived by the owner on Apr 25, 2023. It is now read-only.
escape the project root we compare paths against #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
Strum355
approved these changes
Feb 8, 2021
Contributor
Strum355
left a comment
Strum355
left a comment
There was a problem hiding this comment.
LGTM, nothing stands out : )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjdevries for visibility
clang's libraries internally escapes file paths. so when it gives us back info like "this symbol is in this file", we can't just compare against the raw repo root directory to see if it should be included without escaping it first.