This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Buffer writes to the underlying file #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidaeology
approved these changes
Aug 10, 2020
Contributor
aidaeology
left a comment
aidaeology
left a comment
There was a problem hiding this comment.
Very excited about this change :) LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the program was dominated by many small writes to the output file. This change improves throughput of the indexer significantly.
To index aws-sdk-go, it took 8 minutes for version 0.9.0. Before this change it took about 90 seconds. After this change it takes only 30 seconds.