This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Refine positions during AST traversal to reduce search space #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garobrik
approved these changes
Aug 12, 2020
| }) | ||
|
|
||
| end := start | ||
| for end < len(positions) && positions[end] <= node.End() { |
Contributor
There was a problem hiding this comment.
perf nit since it's a perf PR:
finding end would be faster using another application of sort.Search, but idk how many positions an ast node can span for whether it matters
Contributor
Author
There was a problem hiding this comment.
My assumption is that it's fairly small and I don't want to break cache locality here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do binary search on all positions for a package, which is unnecessary. As we traverse the AST we can only pass along the positions which are valid for the parent (children necessarily fall in the same bounds).