Skip to content

Update packageInformation structure #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Update packageInformation structure #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lsif-java/src/main/scala/com/sourcegraph/lsif_java/commands/SnapshotLsifCommand.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ object SnapshotLsifCommand {
)
s"range(${node.getId}) ${renderPos(node.getStart)} '${p.text}'"
case ("vertex", "packageInformation") =>
s"${node.getName}(${node.getId})"
s"${node.getName} ${node.getVersion}(${node.getId})"
case ("vertex", label) =>
s"${label}(${node.getId})"
case _ =>
Expand Down
2 changes: 1 addition & 1 deletion lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/JdkPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public JdkPackage(String version) {

@Override
public String repoName() {
return String.format("jdk/%s", version);
return "jdk";
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/LsifWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public int emitpackageinformationVertex(Package pkg) {
return emitObject(
lsifVertex("packageInformation")
.setName(pkg.repoName())
.setManager("packagehub")
.setManager("jvm-dependencies")
.setVersion(pkg.version()));
}

Expand Down
2 changes: 1 addition & 1 deletion lsif-semanticdb/src/main/java/com/sourcegraph/lsif_semanticdb/MavenPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public MavenPackage(Path jar, String groupId, String artifactId, String version)

@Override
public String repoName() {
return String.format("maven/%s/%s/%s", groupId, artifactId, version);
return String.format("maven/%s/%s", groupId, artifactId);
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion tests/snapshots/src/main/generated/index-semanticdb/packages
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@ public class Example {
│ │ │ │
v v v │
╭────────────────────────────────────────╮ ╭─────────────┴─────╮
│maven/org.hamcrest/hamcrest-core/1.3(23)│ │referenceResult(76)│
│maven/org.hamcrest/hamcrest-core 1.3(23)│ │referenceResult(76)│
╰────────────────────────────────────────╯ ╰───────────────────╯
2 changes: 1 addition & 1 deletion tests/snapshots/src/main/generated/index-semanticdb/packages-jvm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ public class Example {
│ ││
v v│
╭──────────╮ ╭──────────────┴────╮
│jdk/11(33)│ │referenceResult(35)│
│jdk 11(33)│ │referenceResult(35)│
╰──────────╯ ╰───────────────────╯