Properly fix issue with checkerframework Gradle plugin. #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `lsif-java index` had custom logic to disable the checkerframework Gradle plugin in order to prevent the error "plug-in not found: semanticdb". This commit replaces that custom logic with a proper fix to this bug, which is to automatically inject the SemanticDB compiler plugin jar to the annotation processor path as well as the compile classpath.
|
@Strum355 can you push a new git tag? I’m afk for the next twenty minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
lsif-java indexhad custom logic to disable thecheckerframework Gradle plugin in order to prevent the error
"plug-in not found: semanticdb". This commit replaces that custom logic
with a proper fix to this bug, which is to automatically inject the
SemanticDB compiler plugin jar to the annotation processor path
as well as the compile classpath.