Skip to content

Index SCIP field enclosing_range #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Index SCIP field enclosing_range #838

wants to merge 1 commit into from

Conversation

@CatherineGasnier
Copy link

@CatherineGasnier CatherineGasnier commented Dec 1, 2025 •
edited
Loading

Fixes #833

Populate SCIP field enclosing_range for definitions
6841756 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@CatherineGasnier CatherineGasnier changed the title Fix computeEnclosingRange for method definitions Index SCIP field enclosing_range Dec 1, 2025
@CatherineGasnier
Copy link
Author

CatherineGasnier commented Dec 1, 2025

Issues that I don't know how to fix for now:

  • had to update semanticdb.proto. Would probably need a PR there too?
  • not sure how to unit test
  • had to manually copy the enclosing_range field and its doc from sourcegraph/scip/scip.proto repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Index enclosing_range

1 participant

@CatherineGasnier