Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Codecov to the Sentry extension #6

Merged
merged 17 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@vanesa
Copy link
Member

commented Apr 9, 2019

Add Codecov to the Sentry extension repo.
Part of sourcegraph/sourcegraph#3177.

@vanesa vanesa self-assigned this Apr 9, 2019

@vanesa vanesa marked this pull request as ready for review Apr 9, 2019

},
"node": {
"supportPolicy": ["lts"]
}

This comment has been minimized.

Copy link
@felixfbecker

felixfbecker Apr 9, 2019

Member

We should set these things in https://github.com/sourcegraph/renovate-config if they are desirable (this file should only contain the extends field)

This comment has been minimized.

Copy link
@felixfbecker

felixfbecker Apr 11, 2019

Member

^ not addressed

This comment has been minimized.

Copy link
@vanesa

vanesa Apr 11, 2019

Author Member

Ah sorry, I misunderstood this comment.

vanesa added some commits Apr 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4baf865). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   19.81%           
=========================================
  Files             ?        4           
  Lines             ?      111           
  Branches          ?       25           
=========================================
  Hits              ?       22           
  Misses            ?       89           
  Partials          ?        0
Impacted Files Coverage Δ
src/settings.ts 0% <ø> (ø)
src/extension.ts 0% <0%> (ø)
src/handler.ts 43.24% <50%> (ø)
src/test/stubs.ts 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4baf865...4a08d1d. Read the comment docs.

@sqs

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Can you please give these PRs descriptive titles so other people browsing them know what they're about?

vanesa added some commits Apr 10, 2019

@vanesa vanesa changed the title Vo/add codecov add Codecov to the Sentry extension Apr 10, 2019

Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved src/test/stubs.ts
Show resolved Hide resolved package.json Outdated

@vanesa vanesa requested a review from felixfbecker Apr 10, 2019

@vanesa vanesa merged commit 6fa41d1 into master Apr 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.