Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

HTML comments are not respected in code discussions Markdown #795

@sqs

Description

@sqs

Repro:

Add a code discussions comment with HTML comments where the opening comment and closing comment are on different lines, like:

<!-- Test commenting out

-->

Expected: the whole thing is interpreted as an HTML comment. This is how GitHub works.

Actual: The -- are replaced with a – and the text is shown. (Example: https://sourcegraph.sgdev.org/github.com/sourcegraph/sourcegraph@deprecate-custom-git-uris/-/blob/doc/dev/uri_schemes.md#tab=discussions&threadID=137&commentID=315)

I thought I fixed this in the Markdown package we use in https://github.com/sourcegraph/docsite. So I am assigning myself as well to look into that.

Metadata

Metadata

Assignees

Labels

bugAn error, flaw or fault that produces an incorrect or unexpected result, or behavior.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions