From 316ecbec9aafce3d2500123a68809ef2ba709cfb Mon Sep 17 00:00:00 2001 From: Erik Seliger Date: Thu, 25 Aug 2022 19:27:00 +0200 Subject: [PATCH] batches: Fix multiple tabs racing for URL query state After switching back to wildcard tabs, it was forgotten that before those components would not render at the same time. This causes two issues: - Going to the bulp operations tab doesn't reload so it's unclear where the bulk operation went (noticed that while debugging) - The Bulk operations, Executions and Changesets tabs will all three race for the `visible` (and other, likely) URL query param and keep updating it, leading to an infinite loop of updates until Chrome prevents the loop. --- client/web/src/enterprise/batches/BatchChangeTabs.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/web/src/enterprise/batches/BatchChangeTabs.tsx b/client/web/src/enterprise/batches/BatchChangeTabs.tsx index 9c3958e3706d..1ea6920e0f8f 100644 --- a/client/web/src/enterprise/batches/BatchChangeTabs.tsx +++ b/client/web/src/enterprise/batches/BatchChangeTabs.tsx @@ -6,7 +6,7 @@ import styles from './BatchChangeTabs.module.scss' /** sourcegraph/wildcard `Tabs` with styling applied to prevent CLS on hovering the tabs. */ export const BatchChangeTabs: React.FunctionComponent = props => ( - + ) /** sourcegraph/wildcard `TabsList` with BC visual styling applied. */