This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] [permissions] Revert default behaviour for explicit permissions #54439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to the
user_repo_permissionstable, the default behaviour for explicit permissions changed. Previously, if explicit permissions API was enabled, then all repositories would be treated as restricted, regardless of code host connection configurations.The
user_repo_permissionstable allows us to run permissions syncs and explicit permissions in parallel, but the default behaviour was to have code host connections be marked as unrestricted, unless authorization is enabled. However, not all code hosts support authorization, leading to connections that are always left unrestricted, even if explicit permissions are being used.This PR reverts the default behaviour back to treating a repository as restricted if explicit permissions are enabled.
Test plan
Added unit tests for the new Unrestricted logic. Also tested locally with an "Other Git code host" connection.
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Backport 5ad2474 from #54419