Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@github-actions
Copy link
Contributor

With the switch to the user_repo_permissions table, the default behaviour for explicit permissions changed. Previously, if explicit permissions API was enabled, then all repositories would be treated as restricted, regardless of code host connection configurations.

The user_repo_permissions table allows us to run permissions syncs and explicit permissions in parallel, but the default behaviour was to have code host connections be marked as unrestricted, unless authorization is enabled. However, not all code hosts support authorization, leading to connections that are always left unrestricted, even if explicit permissions are being used.

This PR reverts the default behaviour back to treating a repository as restricted if explicit permissions are enabled.

Test plan

Added unit tests for the new Unrestricted logic. Also tested locally with an "Other Git code host" connection.

<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->

Backport 5ad2474 from #54419

@sourcegraph-bot
Copy link
Contributor

📖 Storybook live preview

@coury-clark coury-clark merged commit 2a6dd1f into 5.1 Jun 29, 2023
@coury-clark coury-clark deleted the backport-54419-to-5.1 branch June 29, 2023 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants