From ef392f3ac2c6160889274e04f582c01b1099e3ad Mon Sep 17 00:00:00 2001 From: Jason Harris Date: Thu, 8 Feb 2024 09:21:51 -0600 Subject: [PATCH 1/2] adjust global styling for kbd element --- .../filters/NewSearchFilters.module.scss | 7 ------- client/wildcard/src/global-styles/code.scss | 17 +++++++++-------- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/client/branded/src/search-ui/results/filters/NewSearchFilters.module.scss b/client/branded/src/search-ui/results/filters/NewSearchFilters.module.scss index f44f9b9df7d7..693597c3f86e 100644 --- a/client/branded/src/search-ui/results/filters/NewSearchFilters.module.scss +++ b/client/branded/src/search-ui/results/filters/NewSearchFilters.module.scss @@ -93,13 +93,6 @@ } } -// @TODO: Jason Harris: element is unuseable unless the following CSS selectors are present. -// We should use these as a base for adjusting the default styling of elements. .keybind { - font-family: var(--font-family-base); - color: var(--text-muted); - background: var(--color-bg-1); - border: 1px solid var(--border-color-2); margin-left: 0.5rem; - padding: 0 0.25rem; } diff --git a/client/wildcard/src/global-styles/code.scss b/client/wildcard/src/global-styles/code.scss index a29cc4517353..c8f91b340290 100644 --- a/client/wildcard/src/global-styles/code.scss +++ b/client/wildcard/src/global-styles/code.scss @@ -34,18 +34,19 @@ code, } kbd { - font-family: var(--code-font-family); - font-size: var(--code-font-size); + background-color: var(--color-bg-2); + border-radius: 3px; + border: 1px solid var(--border-color-2); + box-shadow: inset 0 -2px 0 var(--color-bg-3); + color: var(--text-muted); display: inline-block; - line-height: (16/12); + font-family: var(--font-family-base); + font-size: var(--code-font-size); height: 1.125rem; - padding: 0 0.25rem; + line-height: (16/12); margin: 0 0.125rem; + padding: 0 0.25rem; vertical-align: middle; - border-radius: 3px; - color: var(--body-color); - background-color: var(--color-bg-2); - box-shadow: inset 0 -2px 0 var(--color-bg-3); } // Search examples that link to the results page should use this class. From 8593a319fcfa8a96cad020f71aa349c08f9b2c1b Mon Sep 17 00:00:00 2001 From: Jason Harris Date: Thu, 8 Feb 2024 10:00:59 -0600 Subject: [PATCH 2/2] design tweaks from Taiyab --- client/wildcard/src/global-styles/code.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/client/wildcard/src/global-styles/code.scss b/client/wildcard/src/global-styles/code.scss index c8f91b340290..2a8914c637f2 100644 --- a/client/wildcard/src/global-styles/code.scss +++ b/client/wildcard/src/global-styles/code.scss @@ -34,13 +34,13 @@ code, } kbd { - background-color: var(--color-bg-2); - border-radius: 3px; + background-color: var(--color-bg-1); + border-radius: 4px; border: 1px solid var(--border-color-2); - box-shadow: inset 0 -2px 0 var(--color-bg-3); + box-shadow: inset 0 -2px 0 var(--color-bg-2); color: var(--text-muted); display: inline-block; - font-family: var(--font-family-base); + font-family: var(--monospace-font-family); font-size: var(--code-font-size); height: 1.125rem; line-height: (16/12);