Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@beyang
Copy link
Member

@beyang beyang commented Nov 5, 2018

This PR updates the CHANGELOG.md file to describe any user-facing changes.
This PR does not need to update the CHANGELOG because ...

@beyang beyang requested a review from sqs November 5, 2018 23:45
@beyang beyang requested a review from keegancsmith as a code owner November 5, 2018 23:52
@sqs sqs merged commit bba3c55 into master Nov 5, 2018
@sqs sqs deleted the bl/perm-docs branch November 5, 2018 23:52
BolajiOlajide added a commit that referenced this pull request Apr 16, 2024
* Cancel reading from stdin on Ctrl-C

This is essentially a copy-paste implementation of the ideas presented
in this comment here: golang/go#20280 (comment)

It fixes #775 and helps with the issue described in sourcegraph/src-cli#793 (comment). Not sure if it has unintended side-effects.

* Add comments and remove interface

* update changelog

Co-authored-by: BolajiOlajide <25608335+BolajiOlajide@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants