cleanup code #44
Merged
cleanup code #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 3 3
Lines 120 120
Branches 28 27 -1
=======================================
Hits 103 103
Misses 17 17
Continue to review full report at Codecov.
|
lguychard
reviewed
May 24, 2019
lguychard
suggested changes
May 24, 2019
lguychard
approved these changes
May 31, 2019
Co-Authored-By: Loic Guychard <l.guychard@gmail.com>
Co-Authored-By: Loic Guychard <l.guychard@gmail.com>
This was referenced Jun 5, 2019
felixfbecker
reviewed
Jun 5, 2019
| const repoPattern = /(github\.com|gitlab\.com)\/([^\?\#\/]+\/[^\?\#\/]*)/gi | ||
| export function getParamsFromUriPath(textDocumentURI: string): Params | null { | ||
| let paramsRepo | ||
| let fileMatch |
Contributor
There was a problem hiding this comment.
Declare a type (else they are any)
| "linePatterns": [ | ||
| // List of RegExp patterns that match error handling code, e.g. "throw new Error+\\(['\"]([^'\"]+)['\"]\\)", | ||
| // !! Make sure to capture the error message in a RegExp group !! | ||
| // !! Make sure to capture the error message in a RegExp group and escape special characters to ensure compatibility with JSON Schema!! |
Contributor
There was a problem hiding this comment.
I'd drop the "Schema" because you need to escape to be compliant with JSON (not with the schema)
The exclamation marks seem very aggressive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up code, update comments and readme, use URL API for repo extraction, match with any
throw new TypeError().Addresses: #37 - "Use URL API on getParamsFromUriPath"
#7 - "Doesn't match throw new TypeError()"
#40 - "Sentry extension should wrap the query in double quotes"