Skip to content

Commit

Permalink
monitoring: Increase alert time range (#17269)
Browse files Browse the repository at this point in the history
Increase the time range for the
src_repoupdater_sched_update_queue_length metric from 30 minutes to 2
hours.

This should stop false positives due to expected spikes in the update
queue length when updates are queued due to age.
  • Loading branch information
ryanslade committed Jan 14, 2021
1 parent f449be8 commit 41a72d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion doc/admin/observability/alert_solutions.md
Expand Up @@ -3150,7 +3150,7 @@ with your code hosts connections or networking issues affecting communication wi

**Descriptions:**

- <span class="badge badge-critical">critical</span> repo-updater: 0+ rate of growth of update queue length over 5 minutes for 30m0s
- <span class="badge badge-critical">critical</span> repo-updater: 0+ rate of growth of update queue length over 5 minutes for 2h0m0s

**Possible solutions:**

Expand Down
2 changes: 1 addition & 1 deletion monitoring/definitions/repo_updater.go
Expand Up @@ -184,7 +184,7 @@ func RepoUpdater() *monitoring.Container {
Description: "rate of growth of update queue length over 5 minutes",
Query: `max(deriv(src_repoupdater_sched_update_queue_length[5m]))`,
// Alert if the derivative is positive for longer than 30 minutes
Critical: monitoring.Alert().Greater(0).For(30 * time.Minute),
Critical: monitoring.Alert().Greater(0).For(120 * time.Minute),
Panel: monitoring.Panel().Unit(monitoring.Number),
Owner: monitoring.ObservableOwnerCloud,
PossibleSolutions: "Check repo-updater logs for indications that the queue is not being processed. The queue length should trend downwards over time as items are sent to GitServer",
Expand Down

0 comments on commit 41a72d8

Please sign in to comment.