New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct GitLab integration v1 #1000

Open
sqs opened this Issue Nov 14, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@sqs
Copy link
Member

sqs commented Nov 14, 2018

Draft announcement: sourcegraph/about#41

Milestones:

@sqs sqs added this to the 3.0 milestone Nov 14, 2018

@ijsnow

This comment has been minimized.

Copy link
Contributor

ijsnow commented Dec 3, 2018

JS Distribution

For distribution of JS code for GitLab, we'll make a new entry point for
GitLab similar to the Phabricator extension. GitLab will pull the scripts
from the Sourcegraph instance that the User has configured Souregraph to
point at. This will allow the extension to be ran in a backwards compatible
way without all of our code having to be backwards compatible with
different versions of Sourcegraph and GitLab.

The one difference between the Phabricator extension and the forthcoming
GitLab integration's extensions is that we will take the =CodeHost=
interface implementation from GitLab rather than Sourcegraph code. This is
because it will be easier to keep the selectors and any information that
could change and break the extension closer to the code host itself. This
will also be a completely abstract implementation of handling code hosts
that will work for any new code host looking to integrate directly with
Sourcegraph.

@francisschmaltz

This comment has been minimized.

Copy link
Member

francisschmaltz commented Dec 7, 2018

@sqs Do you have a PR for the features we plan to add?

@nicksnyder nicksnyder modified the milestones: 3.0-preview.2, 3.0 Dec 14, 2018

@ijsnow

This comment has been minimized.

Copy link
Contributor

ijsnow commented Dec 14, 2018

@francisschmaltz I'll be ready for (but not blocked by) mocks for storing settings soon.

I've created a table in GitLab that has an access token, sourcegraph url, and owner (user or group/org). The token is required for the initial implementation due to CORS on Sourcegraph. The owner can be optional (global for a GitLab instance) and the URL will just be sourcegraph.com to start with.

@nicksnyder nicksnyder modified the milestones: 3.0, 3.1 Dec 17, 2018

@nicksnyder nicksnyder changed the title Direct GitLab integration Direct GitLab integration v1 Dec 20, 2018

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Feb 12, 2019

Backlogging this

@nicksnyder nicksnyder modified the milestones: 3.1, Backlog Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment