New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search keyword to enable searching of large file sizes #1624

Open
beyang opened this Issue Jan 3, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@beyang
Copy link
Member

beyang commented Jan 3, 2019

We currently exclude large files (> 1MB) from searches (https://sourcegraph.com/github.com/sourcegraph/sourcegraph@dd08f0db515f5c89e818afadd5e8af6d9250ca5b/-/blob/cmd/searcher/search/store.go#L280). In most cases, this is preferred, as large files are often generated and users do not want to view them in search results.

In some cases, however, a user would like to increase the max file size limit.

Proposal: add a maxFileSize search query keyword that overrides the default max of 1MB.

@beyang beyang self-assigned this Jan 3, 2019

@beyang beyang added this to the 3.1 milestone Jan 3, 2019

@beyang

This comment has been minimized.

Copy link
Member

beyang commented Jan 3, 2019

cc @sqs

@gergelyke

This comment has been minimized.

Copy link

gergelyke commented Jan 4, 2019

Thanks for taking this on @beyang ! Any chance you have a timeline for 3.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment