New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Plan Datadog extension #1732

Closed
vanesa opened this Issue Jan 9, 2019 · 7 comments

Comments

Projects
None yet
5 participants
@vanesa
Copy link
Member

vanesa commented Jan 9, 2019

Test Plan for Datadog Extension

@nicksnyder nicksnyder added this to the 3.0 milestone Jan 9, 2019

@nicksnyder nicksnyder added the test-plan label Jan 9, 2019

@felixfbecker

This comment has been minimized.

Copy link
Member

felixfbecker commented Jan 9, 2019

All the examples in the post are metrics within comments. Is this expected? Could you show an example with actual code?

@felixfbecker

This comment has been minimized.

Copy link
Member

felixfbecker commented Jan 9, 2019

None of the metric links show me any graph. Is this expected?

image

@nicksnyder nicksnyder assigned attfarhan and unassigned slimsag Jan 10, 2019

@attfarhan

This comment has been minimized.

Copy link
Contributor

attfarhan commented Jan 10, 2019

I have the same two questions as Felix above, but LGTM otherwise.

@felixfbecker felixfbecker removed their assignment Jan 10, 2019

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 10, 2019

The metrics aren't visible due to the display setting on the top showing only metrics created within the last hour.
If you change that to 2 days or 1 week, you will see metrics.
image

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 10, 2019

Here is a link to code: https://github.com/NickEnvy/rowboat/blob/b58afbc79b839eb8c54dca391e922de7a5c3aa14/plugins/stats.py

I only generated some metrics for gateway.events.received and guild.messages.create.

@felixfbecker

This comment has been minimized.

Copy link
Member

felixfbecker commented Jan 10, 2019

Confirmed working

@attfarhan attfarhan removed their assignment Jan 11, 2019

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 11, 2019

I am closing this issue since it has been tested.

@nicksnyder nicksnyder closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment