New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while adding public repos to external services #1747

Closed
vanesa opened this Issue Jan 9, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@vanesa
Copy link
Member

vanesa commented Jan 9, 2019

When trying to add public repos to my external services, I get this error:

image

Json: cannot unmarshal string into Go struct field GitHubConnection.repos of type []string

I typed in the markdown instead of tabbing to auto-complete and the token had my private GitHub access token which I only removed for the screenshot.

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 9, 2019

Hmm, I am not able to reproduce. I realized that my test instructions did not include docker pull sourcegraph/server:insiders so it is possible you were using an old build (if you were testing on insiders). Can you test this again after running docker pull sourcegraph/server:insiders?

@nicksnyder nicksnyder added this to the 3.0 milestone Jan 9, 2019

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 10, 2019

I was running an uptodate build:

>     --volume /tmp/sourcegraph/config:/etc/sourcegraph \
>     --volume /tmp/sourcegraph/data:/var/opt/sourcegraph \
>     sourcegraph/server:insiders
Unable to find image 'sourcegraph/server:insiders' locally
insiders: Pulling from sourcegraph/server

But I'll run it again to be sure.

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 10, 2019

If you can still reproduce, can you copy paste the exact steps and config you are using?

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 10, 2019

I couldn't reproduce it, so maybe it was just a glitch.

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 10, 2019

Oh, I was able to trigger this error message by just putting invalid input.

image

Is this error message not clear to you?

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 10, 2019

Oh, I think the problem is that once an error happens, updates don't succeed

nicksnyder added a commit that referenced this issue Jan 11, 2019

nicksnyder added a commit that referenced this issue Jan 11, 2019

tsenart added a commit that referenced this issue Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment