New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover content rendered backwards #2120

Open
vanesa opened this Issue Feb 1, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@vanesa
Copy link
Member

vanesa commented Feb 1, 2019

Steps to reproduce:

  1. Open http://localhost:3080/github.com/sourcegraph/sourcegraph/-/blob/client/browser/src/libs/gitlab/file_info.ts#L13:5 and hover over getFilePathsFromCodeView
  2. Open https://sourcegraph.com/github.com/sourcegraph/sourcegraph@master/-/blob/client/browser/src/libs/gitlab/file_info.ts#L13:5 and hover over getFilePathsFromCodeView
  3. Notice how on the local hover the hover content title is shown after the info, while on Sourcegraph.com it shows it reverse.

Local:
image

Sourcegraph.com:
image

Expected behavior:

Have the content elements of the hover cards render in the same order.

Actual behavior:

Locally, the hover content signature is rendered underneath the docstring.

@sqs sqs added the code-intel label Feb 1, 2019

@sqs sqs added this to the Backlog milestone Feb 1, 2019

@sqs

This comment has been minimized.

Copy link
Member

sqs commented Feb 1, 2019

I think this is due to one being from basic-code-intel and the other from the sourcegraph/typescript extension. They should be consistent, and I think it makes most sense for the signature to be above the docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment