Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations quality #2380

Closed
lguychard opened this Issue Feb 20, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@lguychard
Copy link
Member

lguychard commented Feb 20, 2019

The desired outcome of this project is to increase the product quality, stability and code quality of our integrations, and more specifically of the browser extension.

Goals

  • Error handling: no more console.error(err); return null
  • Reactive to the DOM: no more one-time inject() calls
  • Tested: prevent regressions

Metrics

Plan

Issues labeled code-nav browser-extension

Test/review plan

  • Code reviewer:
  • Tester:
@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Feb 26, 2019

The metrics section doesn't clearly define what success looks like (or even what the current baseline is).

Recording the current baseline would be incredibly valuable and then you can set a goal relative to that baseline (e.g. 50% fewer sentry alerts, 50% browser extension installs)

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Mar 18, 2019

Tracking issues are supposed to reflect what a given team is going to get done in a given release cycle.

Here are two examples of good tracking issues:

Please close this issue with an explanation about what you accomplished in 3.2 and create a new one for 3.3 that reflects what you plan to do in that release cycle.

@lguychard lguychard closed this Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.