Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code intelligence quality and reduce false positives #2452

Closed
chrismwendt opened this Issue Feb 26, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@chrismwendt
Copy link
Contributor

chrismwendt commented Feb 26, 2019

Code intelligence has broken (I mean P0 broken) a few times in the past couple of weeks in ways that could have been prevented by E2E and unit tests. Also, basic-code-intel is rather slow on large repositories and often times reports false positives in definitions and references, which hampers adoption.

Plan

Test/review plan

  • Symbols perf improvements have tests + benchmarks
  • E2E/unit tests will be run in CI
  • Reducing false positives will have unit tests
@chrismwendt

This comment has been minimized.

Copy link
Contributor Author

chrismwendt commented Mar 5, 2019

  • Indicate that basic code intel hovers/defs/refs are fuzzy in the UI (could be a "Fuzzy" label in the tooltip, or other UI treatment in the defs/refs panel)

@sqs Do you have a link for this? added link

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Mar 18, 2019

Please close this tracking issue for 3.2 and create a new tracking issue for 3.3 that includes the unfinished work (if still appropriate).

@nicksnyder nicksnyder modified the milestones: 3.2, Backlog Mar 19, 2019

@chrismwendt

This comment has been minimized.

Copy link
Contributor Author

chrismwendt commented Mar 20, 2019

3.3 tracking issue #2856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.