Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3 Plan for Sentry extension #3177

Closed
vanesa opened this Issue Apr 2, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@vanesa
Copy link
Member

commented Apr 2, 2019

The focus for the 3.3 release cycle will be getting the Sentry extension working 100% for Go and then adding support for the other primary languages.

Sentry repo: WIP: https://github.com/sourcegraph/sourcegraph-sentry

  • Add codecov to sourcegraph-sentry repo
  • Node.js (TypeScript/JavaScript): Sentry extension renders line decorations with "View logs in Sentry >>" for lines that resemble log print statements that link to the matching live logs on Sentry.
    • Create (but don't merge) a PR to update the README to include example links where this extension will work for this language.
      • Link to Sourcegraph.com file/line where decoration should appear
      • Link to GitHub.com file/line where decoration should appear
      • Link to GitHub.com PR diff file/line where decoration should appear
    • Implement log statement are detection using hard coded logic for this language.
      • 80% test coverage
      • Merge the README PR from the first step. The links should now work.
  • If user input is needed to configure the Sentry account (e.g., needing the project ID to construct the URLs), a progressive flow to complete setup:
    • Line decorations are still shown with a dimmer color and read "Missing Sentry [missing config]"
    • An editor/title action to "Set Sentry [missing config]" is shown that prompts the user for the value
    • If the Sentry organization is missing in the user settings, a link to the user's setting $SOURCEGRAPH_URL/users/$USER/settings is rendered with the title action to "Set Sentry organization".
    • Also check for user errors e.g. if there is no json added to settings for the Sentry extension. Handle like missing configurations.
    • 80% test coverage
  • "(Show/Hide) log links" action in command palette and a Sentry icon action item on the editor/title
    • Implementation done
    • 80% test coverage
    • Update the README to document this.
  • Go: Sentry extension renders line decorations with "View logs in Sentry >>" for lines that resemble log print statements that link to the matching live logs on Sentry.
    • Create (but don't merge) a PR to update the README to include example links where this extension will work for this language.
      • Link to Sourcegraph.com file/line where decoration should appear
      • Link to GitHub.com file/line where decoration should appear
      • Link to GitHub.com PR diff file/line where decoration should appear
    • Implement log statement are detection using hard coded logic for this language.
      • 80% test coverage
      • Merge the README PR from the first step. The links should now work.
  • Python: Sentry extension renders line decorations with "View logs in Sentry >>" for lines that resemble log print statements that link to the matching live logs on Sentry.
    • Create (but don't merge) a PR to update the README to include example links where this extension will work for this language.
      • Link to Sourcegraph.com file/line where decoration should appear
      • Link to GitHub.com file/line where decoration should appear
      • Link to GitHub.com PR diff file/line where decoration should appear
    • Implement log statement are detection using hard coded logic for this language.
      • 80% test coverage
      • Merge the README PR from the first step. The links should now work.
  • Java: Sentry extension renders line decorations with "View logs in Sentry >>" for lines that resemble log print statements that link to the matching live logs on Sentry.
    • Create (but don't merge) a PR to update the README to include example links where this extension will work for this language.
      • Link to Sourcegraph.com file/line where decoration should appear
      • Link to GitHub.com file/line where decoration should appear
      • Link to GitHub.com PR diff file/line where decoration should appear
    • Implement log statement are detection using hard coded logic for this language.
      • 80% test coverage
      • Merge the README PR from the first step. The links should now work.
  • The README.md file and other information shown on the extension's registry page (e.g., https://sourcegraph.com/extensions/sourcegraph/sentry) is informative and up to date with respect to:
    • Features
    • Usage instructions
    • Compatibility (which versions of Sourcegraph, which code hosts, and which forms of the external service (e.g., Sentry cloud-hosted vs. Sentry self-hosted))
  • If the extension is mentioned on the Sentry's website, that material is also kept up to date with what we have on our own site.

Customers (not exhaustive):

@vanesa vanesa added this to the 3.3 milestone Apr 2, 2019

@vanesa vanesa self-assigned this Apr 2, 2019

@vanesa vanesa added the extensions label Apr 2, 2019

@nicksnyder nicksnyder changed the title 3.3 Plan for Sentry and Datadog extensions 3.3 Plan for Sentry extension Apr 4, 2019

@felixfbecker

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

👍 for the 80% test coverage goal

@nicksnyder nicksnyder added the roadmap label Apr 8, 2019

@nicksnyder nicksnyder referenced this issue Apr 8, 2019

Open

3.4 plan for Datadog extension #3297

0 of 96 tasks complete

vanesa added a commit to sourcegraph/sentry that referenced this issue Apr 11, 2019

add Codecov to the Sentry extension (#6)
Add Codecov to the Sentry extension repo.
Part of sourcegraph/sourcegraph#3177.

@nicksnyder nicksnyder referenced this issue Apr 17, 2019

Closed

Sentry extension #2628

18 of 18 tasks complete
@slimsag

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Closing since the 3.3 window has closed.

@slimsag slimsag closed this Apr 18, 2019

@vanesa vanesa modified the milestones: 3.3, Backlog Apr 18, 2019

@nicksnyder

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@vanesa Can you create a new issue "3.4 Plan for Sentry extension" that includes remaining necessary work (i.e. unchecked boxes on this issue)?

@vanesa vanesa referenced this issue Apr 22, 2019

Open

3.4 Plan for Sentry extension #3536

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.