Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy-sourcegraph-docker: make Jaeger optional, always deploy otel-collector #40455

Closed
bobheadxi opened this issue Aug 17, 2022 · 0 comments · Fixed by sourcegraph/deploy-sourcegraph-docker#848 or sourcegraph/deploy-sourcegraph-docker#849
Assignees

Comments

@bobheadxi
Copy link
Member

No description provided.

@bobheadxi bobheadxi self-assigned this Aug 17, 2022
bobheadxi added a commit to sourcegraph/deploy-sourcegraph-docker that referenced this issue Sep 6, 2022
#849 took a conservative approach to sourcegraph/sourcegraph#40455 by keeping Jaeger around. I've since reached out to the only customer using this deployment mechanism (https://sourcegraph.slack.com/archives/C012V43N8E7/p1662138872279299) which indicates there is no strong interest in keeping Jaeger around, so this change removes it entirely.
bobheadxi added a commit that referenced this issue Sep 7, 2022
Now that all our core deployment methods bundle OpenTelemetry Collector by default (#40456, #40457, #40455), we can now switch over to enabling OpenTelemetry by default. This change also:

- removes the default `traceURL` template, since the Jaeger instance it points to by default no longer exists on most deployments.
- fixes the behaviour of `observability.tracing` config, and adds testing
- refactors some things in `internal/trace` to be OpenTelemetry-first

Closes #39399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant