Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Extension V2 #4756

Open
vanesa opened this issue Jul 1, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@vanesa
Copy link
Member

commented Jul 1, 2019

Sentry Extension V2

Feature request description

Currently, the Sentry extension does not communicate with the Sentry API. Instead, the extension renders links to Sentry by matching error logging code patterns presented in the file and taking the user's configurations into account. This can lead to erroneous project matching, especially if a file sends logs to multiple projects.
For v2 of the extension we want to use the Sentry API to increase the matching accuracy between the lines of code producing the error logs and the corresponding Sentry issue pages.

Plan (WIP)

  • Setup connection with Sentry API using Auth token provided by the user in the extension settings, proxying through cors anywhere.
  • As a first step to improve project matching:
    • Only render existing issues
    • Retrieve projects from Sentry and offer auto-complete in settings to map projects with file paths/repos.
    • Optional: Retrieve projects from Sentry, iterate through projects to match error logging code with issue title.
  • Render issues count number next to the Sentry link.
    Concern: Depending on how many projects and issues exist, this could lead to performance issues.

@vanesa vanesa self-assigned this Jul 2, 2019

@vanesa vanesa added the code-nav label Jul 2, 2019

@lguychard lguychard referenced this issue Jul 3, 2019

Closed

Code Nav: 3.6 Tracking Issue #4639

3 of 4 tasks complete
@felixfbecker

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Note we don't currently have versioning support for extensions. I would recommend using a feature flag instead (setting a token can act as a feature flag too, i.e. progressive enhancement).

@felixfbecker felixfbecker added this to the 3.6 milestone Jul 8, 2019

@keegancsmith keegancsmith modified the milestones: 3.6, 3.7 Jul 15, 2019

@keegancsmith

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Vanesa is currently out sick, so assuming work will continue on this and bumping to the next milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.