Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using *_CONFIG_FILE env vars, allow temporary edits to the configuration #4912

Closed
slimsag opened this issue Jul 16, 2019 · 0 comments · Fixed by #5203

Comments

@slimsag
Copy link
Member

commented Jul 16, 2019

In some cases when using the EXTSVC_CONFIG_FILE, SITE_CONFIG_FILE, etc. env vars it is useful to allow temporary edits to the configuration instead of rejecting it.

In particular, this is useful when:

  1. Testing a configuration change quickly before adding it to your configuration. e.g. this is important when Sourcegraph is not deployed with zero-downtime and several config edits would result in a lot of downtime.
  2. A script of some sort updates the configuration in some automatic fashion.

Reported by https://app.hubspot.com/contacts/2762526/company/407948923

@slimsag slimsag added the site-config label Jul 16, 2019

@slimsag slimsag self-assigned this Jul 16, 2019

@slimsag slimsag added this to the Backlog milestone Jul 16, 2019

slimsag added a commit that referenced this issue Aug 14, 2019
add option for allowing temp edits when using *_CONFIG_FILE env vars
This adds two new environment variables: `EXTSVC_CONFIG_ALLOW_EDITS` and
`SITE_CONFIG_ALLOW_EDITS` which when `true` allow edits to be made to the
external service config and site config even when loading configuration via
a file using `EXTSVC_CONFIG_FILE` or `SITE_CONFIG_FILE`.

For why someone would want to do this, see #4912 -- in particular this helps
a large customer try out options easily before comitting them (which involves
some downtime as Sourcegraph must restart.) It is also something we do in dev
environments today.

Fixes #4912
slimsag added a commit that referenced this issue Aug 14, 2019
add option for allowing temp edits when using *_CONFIG_FILE env vars (#…
…5203)

This adds two new environment variables: `EXTSVC_CONFIG_ALLOW_EDITS` and
`SITE_CONFIG_ALLOW_EDITS` which when `true` allow edits to be made to the
external service config and site config even when loading configuration via
a file using `EXTSVC_CONFIG_FILE` or `SITE_CONFIG_FILE`.

For why someone would want to do this, see #4912 -- in particular this helps
a large customer try out options easily before comitting them (which involves
some downtime as Sourcegraph must restart.) It is also something we do in dev
environments today.

Fixes #4912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.