New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking command palette on /start scrolls to bottom of page #631

Open
sqs opened this Issue Nov 1, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@sqs
Copy link
Member

sqs commented Nov 1, 2018

On https://sourcegraph.com/start when you click the command palette, it scrolls to the bottom of the page and does not open the command palette.

screenshot from 2018-11-01 09-35-46

@sqs sqs added bug extensions labels Nov 1, 2018

@sqs sqs added this to the October 2018 milestone Nov 1, 2018

@nicksnyder nicksnyder modified the milestones: October 2018, November 2018 Nov 2, 2018

@sqs sqs modified the milestones: November 2018, 3.0-preview Nov 10, 2018

@sqs

This comment has been minimized.

Copy link
Member

sqs commented Dec 5, 2018

This no longer happens if you remove the autofocus from the command palette search field.

@sqs sqs modified the milestones: 3.0-preview, 3.0 Dec 5, 2018

@nicksnyder nicksnyder modified the milestones: 3.0-preview.2, 3.0 Dec 14, 2018

@sqs sqs self-assigned this Dec 31, 2018

@sqs sqs added the release-blocker label Dec 31, 2018

@sqs sqs removed their assignment Jan 7, 2019

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 10, 2019

Any update here?

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 10, 2019

Yes, deleting display:block would solve it but will work on a better solution.
PR: #1767

@lguychard

This comment has been minimized.

Copy link
Member

lguychard commented Jan 11, 2019

I think the autofocus prop of CommandList may be the issue:

this sometimes results in the page being scrolled to the bottom

[EDIT] nevermind, this was already mentioned in quinn's comment. Nevertheless, finding out why autofocus is not an issue on other webapp pages, but is an issue on /start will solve this & as a last resort, setting autofocus to false is probably a better fix than removing display:block

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 12, 2019

Thanks @lguychard! Just pushed a better solution #1767 using ref to apply the autofocus directly on the DOM element.

@francisschmaltz

This comment has been minimized.

Copy link
Member

francisschmaltz commented Jan 13, 2019

@vanesa @lguychard this is still occurring for me on sourcegraph.com. Is this resolved?

@ggilmore

This comment has been minimized.

Copy link
Contributor

ggilmore commented Jan 13, 2019

@francisschmaltz I just re-deployed sourcegraph.com. Could you try again?

@francisschmaltz

This comment has been minimized.

Copy link
Member

francisschmaltz commented Jan 13, 2019

Mobile right now. Will in a few hours
Verified this is still an issue.

@ggilmore

This comment has been minimized.

Copy link
Contributor

ggilmore commented Jan 13, 2019

I just tried it and this is still an issue. #1767 is still open

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 14, 2019

Yes, sorry @ggilmore and @francisschmaltz , waiting for review to merge.

@sqs sqs removed the release-blocker label Jan 14, 2019

@sqs

This comment has been minimized.

Copy link
Member

sqs commented Jan 14, 2019

Removing release-blocker because in reality we would be OK shipping the release without this fixed (because this only occurs on Sourcegraph.com not self-hosted instances, so users will get the fix when we redeploy, which we can do at any time).

@nicksnyder nicksnyder modified the milestones: 3.0-beta, 3.0 Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment