New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension request: See Datadog metrics #655

Open
sqs opened this Issue Nov 2, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@sqs
Copy link
Member

sqs commented Nov 2, 2018

As a developer whose code is instrumented for Datadog, I would like to be able to easily

  • v1: jump to the Datadog page for a metrics/instrumentation call in my code files on Sourcegraph/GitHub/etc.
  • v2: view a live summary of the data inline on my code files

The v1 would add a line annotation similar to the one for LightStep (#722):

image

@sqs sqs added this to the Backlog milestone Nov 2, 2018

@sqs sqs removed the c-848415 label Nov 3, 2018

@sqs sqs modified the milestones: Backlog, 3.0 Nov 26, 2018

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Dec 10, 2018

WIP: https://github.com/sourcegraph/sourcegraph-datadog-metrics

Current demo: https://cl.ly/e8be6b573469

Code that generates Datadog metrics is detected by the extension and a link to the metric is generated inline.
The following steps are planned for this week:

  • fix the generated url to create the link to the metric, as the current regex is not extracting the correct name for the metric.
  • Once this works, check if it would make sense to use symbol search to match the statsd code to have more reliable matching.
  • Once the statsd code detection is improved, render information of the given metric inline.
@felixfbecker

This comment has been minimized.

Copy link
Member

felixfbecker commented Dec 11, 2018

@vanesa see if you can generate an embed URL for metrics that could be displayed in the hover: https://docs.datadoghq.com/graphing/dashboards/shared_graph/

@nicksnyder nicksnyder modified the milestones: 3.0-preview.2, 3.0 Dec 14, 2018

@vanesa

This comment has been minimized.

Copy link
Member

vanesa commented Jan 7, 2019

Latest progress:

  • generated URL links to the right metric.

RE embedded graph: Currently the datadog API is designed to generate a graph that will be placed statically as a code snippet in html. This graph is listed on their embedded graphs page, even after being revoked. I don't think it's a good idea to clutter that page with generated graphs. I want to talk to datadog and ask if they can add temporary graphs or at least make it possible to delete graphs.

@sqs

This comment has been minimized.

Copy link
Member Author

sqs commented Jan 14, 2019

The 3.0-beta deliverable is done; removing milestone.

@sqs sqs modified the milestones: 3.0-beta, Backlog Jan 14, 2019

@lguychard

This comment has been minimized.

Copy link
Member

lguychard commented Feb 8, 2019

Would a possible path forwards on this be to:

Eg., given the following existing embeds:

image

A user hovering trace.startSpan(ctx, "account:prod") would see in the hover the graph "Avg of aws.ec2.host_ok over account:prod".

This is possibly even better than generating temp graphs on the fly, because users would only see user-defined graphs, with queries that are relevant to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment