New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search configuration data #670

Open
sqs opened this Issue Nov 3, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@sqs
Copy link
Member

sqs commented Nov 3, 2018

A request to be able to see search results in files that do not exist in a Git repository, such as configuration files served by a system like etcd/Zookeeper. This would be provided by a Sourcegraph extension using the search result provider API. It would eventually run on the backend but TBD on whether that would be in scope for 3.1 (highly unlikely running it on the backend too would be fully ready, it might be feature-flagged off by default).

@sqs sqs added search plan labels Nov 3, 2018

@sqs sqs added this to the November 2018 milestone Nov 3, 2018

@sqs sqs modified the milestones: November 2018, 3.0-preview, 3.0 Nov 10, 2018

@sqs

This comment has been minimized.

Copy link
Member Author

sqs commented Nov 14, 2018

Update: The Search GitHub issues project on the roadmap is building the extension APIs necessary for this. I am pushing this back one month and we will reevaluate it then when we have the extension APIs necessary for this.

@sqs sqs removed the plan label Nov 14, 2018

@keegancsmith

This comment has been minimized.

Copy link
Member

keegancsmith commented Nov 26, 2018

We are thinking of creating a search provider which recursively monitors a directory on a filesystem. The provider will expose what it finds on the FS via HTTP. This seems like a simple approach for developers to add integration for zookeeper/etc since they will just need to code a sync daemon. Additionally from an operational perspective this is relatively easy to understand and manage. @andyfangdz would this seem like a decent way to extend sourcegraph search?

@andyfangdz

This comment has been minimized.

Copy link

andyfangdz commented Nov 26, 2018

@keegancsmith thanks for updating this issue with the approach! The approach of monitoring a FS makes a lot of sense, and we would really appreciate it if this is available.

@nicksnyder nicksnyder modified the milestones: 3.0-preview.2, 3.0, 3.1 Dec 14, 2018

@sqs sqs added the roadmap label Jan 25, 2019

@sqs

This comment has been minimized.

Copy link
Member Author

sqs commented Jan 25, 2019

We will (tentatively, to be planned for 3.1 together with the team) target this extension instead of #962 for 3.1 because this one is simpler.

@sqs sqs changed the title Extension request: search files that do not live in a repository Search configuration data Jan 25, 2019

@sqs sqs modified the milestones: 3.1, Backlog Jan 30, 2019

@sqs sqs removed the roadmap label Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment