New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub user authentication #964

Closed
sqs opened this Issue Nov 13, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@sqs
Copy link
Member

sqs commented Nov 13, 2018

Closes #539

Shipping in 3.0-preview:

  • GitHub and GitLab auth behind a feature flag (experimentalFeatures).
  • GitHub authz (requires GitHub auth, which is behind a feature flag)
  • GitLab authz

Remaining TODO

  • Add option to disable sign-up via GitHub (analogous to disallowing open sign-ups for builtin)
  • Enable on dogfood
  • Enable on sourcegraph.com (and fix the existing login bug there)

@sqs sqs added the roadmap label Nov 13, 2018

@sqs sqs added this to the 3.0-preview milestone Nov 13, 2018

@nicksnyder nicksnyder modified the milestones: 3.0-preview, 3.0 Dec 14, 2018

@nicksnyder

This comment has been minimized.

Copy link
Member

nicksnyder commented Jan 7, 2019

@beyang what is the current state of this issue?

If this is release blocking for 3.0, please add the release blocking label.

Otherwise, if this isn't going to get done in the next week, please remove it from the 3.0 milestone.

@beyang

This comment has been minimized.

Copy link
Member

beyang commented Jan 11, 2019

Live on sourcegraph.com

@beyang beyang closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment