Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: ensure the redirect URL always starts with a single slash #10167

Merged
merged 3 commits into from Apr 24, 2020

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Apr 24, 2020

@unknwon unknwon requested a review from beyang as a code owner April 24, 2020 06:16
@unknwon unknwon requested a review from a team April 24, 2020 06:17
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #10167 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #10167   +/-   ##
=======================================
  Coverage   42.75%   42.75%           
=======================================
  Files        1348     1348           
  Lines       74116    74117    +1     
  Branches     6651     6651           
=======================================
+ Hits        31688    31689    +1     
  Misses      39566    39566           
  Partials     2862     2862           
Flag Coverage Δ
#unit 42.75% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
cmd/frontend/auth/redirect.go 100.00% <100.00%> (ø)

cmd/frontend/auth/redirect.go Outdated Show resolved Hide resolved
unknwon and others added 2 commits April 24, 2020 17:31
Co-Authored-By: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
@unknwon unknwon merged commit bde46f4 into master Apr 24, 2020
@unknwon unknwon deleted the jc/safe-redirect branch April 24, 2020 10:06
@unknwon unknwon mentioned this pull request Apr 25, 2020
notjrbauer pushed a commit to notjrbauer/sourcegraph that referenced this pull request Apr 25, 2020
…cegraph#10167)

Co-Authored-By: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
unknwon added a commit that referenced this pull request Apr 26, 2020
Co-Authored-By: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
unknwon added a commit that referenced this pull request Apr 26, 2020
Co-Authored-By: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
This was referenced Apr 28, 2020
@nicksnyder
Copy link
Contributor

I think this deserves an entry in our changelog, what do you think?

@nicksnyder
Copy link
Contributor

Oh I see that you updated the changelog in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants