Transparent encryption and decryption for all tables that contain secrets or tokens #14214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unit tests exist
Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com>
Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com>
This allow for types that can decrypt and encrypt themselves. However, it causes an issue with what encryptor to use
Co-authored-by: Asdine El Hrychy <asdine.elhrychy@gmail.com>
Ensuring the new types honour ConfiguredToEncrypt so that they can transparently encrypt and decrypt in the future.
…/encoding # Conflicts: # internal/secret/encryptor.go # internal/secret/encryptor_test.go # internal/secret/init.go
…/encoding # Conflicts: # internal/secret/scanner.go # internal/secret/scanner_test.go # migrations/frontend/bindata.go
unknwon
changed the title
Closed
4 tasks
Closed
4 tasks
47 tasks
asdine
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
This looks good to me but I feel like the boilerplate needed to encrypt a single field is still a bit too big.
We could leverage the fact that the encryption functions are available from everywhere to try to make it as transparent as possible. I have proposed a lead in a comment but not sure if that's enough
…/encoding # Conflicts: # migrations/frontend/bindata.go
Codecov Report
@@ Coverage Diff @@
## main #14214 +/- ##
==========================================
- Coverage 52.08% 51.74% -0.34%
==========================================
Files 1536 1536
Lines 78644 77819 -825
Branches 7024 6939 -85
==========================================
- Hits 40958 40266 -692
+ Misses 33986 33925 -61
+ Partials 3700 3628 -72
|
|
Since no real encryption is in place yet, there will be no harm to data if any application code behaves unexpected. Merging as-is and happy to address any post-merge comments! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encrypts and decrypts secrets columns in our database transparently.
Notes:
event_logs.argumentis left out, see discussions in Slack.repo.metadatais not encrypted because we normalized most of its value and decided not worth encrypting.Co-authored-by: Dax McDonald 31839142+daxmc99@users.noreply.github.com