New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote repository connection checking #2102
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your explanation makes sense and this propose change generally looks correct to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping with this!
Thanks for the suggestions and review 🙇 |
Previously, the frontend would neglect to check that the repository is associated with a GitHub external service in addition to checking that the repository hostname is
github.com
before finding an access token and looking up the repository on GitHub.com via HTTPS.This adds a check to make sure the repository is associated with the external service before using the token from the external service.
Fixes #1856