New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set overflow:auto for hover content title #2119

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@vanesa
Copy link
Member

vanesa commented Feb 1, 2019

Issue #1686 : When using the browser extension on GitHub, if the hover overlay has a long title that surpasses the box width, the entire content scrolls horizontally. However, the user would expect only the title to scroll.

Solution: Add overflow: auto to the content title area.

@vanesa vanesa requested review from chrismwendt and lguychard as code owners Feb 1, 2019

@vanesa vanesa requested a review from felixfbecker Feb 11, 2019

@@ -50,6 +50,7 @@
pre {
&:not(:last-child) {
margin-bottom: 0.5rem;
overflow: auto;

This comment has been minimized.

@felixfbecker

felixfbecker Feb 11, 2019

Member

why not the last child, and why the p and pre tags instead of __row?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment