New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use divs instead of ul li to avoid GitHub styling #2233

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@vanesa
Copy link
Member

vanesa commented Feb 10, 2019

Problem (issue #1765): Our Ext debug menu is showing a bullet point due to GitHub's css styling the li.

Solution: Use divs instead of ul > li to avoid external styling and also improve the appearance of the menu from this:
image

to this:
image

@vanesa vanesa requested a review from ijsnow as a code owner Feb 10, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #2233 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/search/backend/backend.go 94.91% <0%> (+1.69%) ⬆️
@@ -16,6 +16,7 @@ All notable changes to Sourcegraph are documented in this file.
- File match search results now show full repo name if there are results from mirrors on different code hosts (e.g. github.com/sourcegraph/sourcegraph and gitlab.com/sourcegraph/sourcegraph)

### Fixed
- The extension debug menu no longer shows a bullet point.

This comment has been minimized.

@felixfbecker

felixfbecker Feb 13, 2019

Member

I don't think bext changes go here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment