Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccessible links in documentation #269

Merged

Conversation

@ianlopshire
Copy link
Contributor

commented Oct 4, 2018

This PR does not need to update the CHANGELOG because it does not include any user-facing changes.

closes #261

@ianlopshire ianlopshire requested review from beyang and keegancsmith as code owners Oct 4, 2018

@ianlopshire

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2018

https://sourcegraph.sgdev.org/github.com/sourcegraph/website/-/blob/STYLEGUIDE.md in style.md is still inaccessible. Perhaps that document should be pulled into this repo somewhere else publicly accessible.

@beyang

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

@ianlopshire thanks for this PR! Could you sign the CLA so we can merge this?

@keegancsmith

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

I believe for smaller changes such as this, we don't need the CLA signed. We will be updating our automation and policy soon. As such I am going to merge this. If I am incorrect, lets revert until signed. cc @dadlerj @sqs

@keegancsmith keegancsmith merged commit 05e761f into sourcegraph:master Oct 5, 2018

1 check failed

cla-bot Contributor has not signed the CLA
Details
@felixfbecker

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

This broke CI

@keegancsmith

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

Fixed by 6ebd417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.