Wildcard: <Card /> migration
#29989
Merged
Wildcard: <Card /> migration
#29989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
commented
Jan 21, 2022
umpox
commented
Jan 21, 2022
| {children} | ||
| </Component> | ||
| ) | ||
| export const Card = React.forwardRef(({ children, className, as: Component = 'div', ...attributes }, reference) => { |
There was a problem hiding this comment.
Note: I have removed the interactive variant prop.
Reasoning: It seems better to me just to style the card when it is used as a button element, which is all we would use the interactive prop for, as far as I can tell.
Doing it this way also ensures nobody accidentally styles div card like it would be interactive
umpox
commented
Jan 21, 2022
| as?: React.ElementType | ||
| } | ||
|
|
||
| export const CardFooter = React.forwardRef( |
There was a problem hiding this comment.
Added CardFooter. We had usage in the application and this wasn't implemented in the original Card PR
github-actions
bot
added
the
frontend-platform
|
Notifying subscribers in CODENOTIFY files for diff e136905...fa5511e.
|
tjkandala
approved these changes
Jan 21, 2022
davejrt
pushed a commit
that referenced
this pull request
Jan 26, 2022
davejrt
pushed a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27681
Description
Automated migration of the
card card-*styles to the<Card />WIldcard component. Powered by this codemod: sourcegraph/codemod#73 (This PR is basically super rough as it just required tweaking an existing codemod to migrate. Migration is priority here, will cleanup codemod afterwards)This PR:
card-*classes to the Wildcard<Card />componentCardFooterWildcard componentNotes
CardBodyandCardthat could be affected and removed some redundant padding styles!