New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if user adds filter duplicate, prioritize their scope name to show chip #348

Merged
merged 4 commits into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@vanesa
Member

vanesa commented Oct 9, 2018

If a user adds a search scope, which value is already been set in org/global/user configurations under a different search scope name, prioritize the user's search scope name.

This PR updates the CHANGELOG.md file to describe any user-facing changes.

@vanesa vanesa requested a review from felixfbecker as a code owner Oct 9, 2018

@vanesa vanesa requested a review from nicksnyder Oct 9, 2018

Show outdated Hide outdated src/search/results/SearchResults.tsx Outdated
Show outdated Hide outdated src/search/results/SearchResults.tsx Outdated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 10, 2018

Codecov Report

Merging #348 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/gitserver/server/cleanup.go 63.72% <0%> (-1.48%) ⬇️

codecov-io commented Oct 10, 2018

Codecov Report

Merging #348 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/gitserver/server/cleanup.go 63.72% <0%> (-1.48%) ⬇️

@vanesa vanesa merged commit b156d6e into master Oct 11, 2018

1 check passed

buildkite/sourcegraph Build #21690 passed (4 minutes, 28 seconds)
Details

@vanesa vanesa deleted the vo/search-scope-dash-issue branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment