Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dark theme the default #409

Closed
wants to merge 1 commit into from

Conversation

@yevbar
Copy link
Contributor

commented Oct 16, 2018

This PR updates the CHANGELOG.md file to describe any user-facing changes.

This makes dark theme the default for the Sourcegraph web application. I was digging through the repository using Sourcegraph and found the initialization for the theme here

I'm doing this because dark mode is amazing, feel free to close 馃槢

@yevbar yevbar requested a review from felixfbecker as a code owner Oct 16, 2018

@sourcegraph-bot

This comment has been minimized.

Copy link

commented Oct 16, 2018

Thanks for the contribution, @yevbar!

You should receive feedback on your pull request within a few days. If you haven't already, please read through the contributing guide, and ensure that you've signed the CLA.

Did you run into any issues when creating this PR? Please describe them in an issue so we can make the experience better for the next contributor.

@yevbar

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

Read through the contributing guide and think it's better off as a PR since it's not terribly structural.

Also signed the CLA

@nicksnyder nicksnyder requested review from sqs and francisschmaltz and removed request for felixfbecker Oct 16, 2018

@nicksnyder

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

I think we are happy with the default as it is but I will defer to @sqs and @francisschmaltz. If you want to configure the default for all users on your instance, you should be able to configure htmlHeadTop with some javascript that sets the local storage value if it isn't already set.

@slimsag

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

dark mode FTW; +1 for making it the default if my vote counts :)

@yevbar

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

Hey @sqs! I love dark theme 馃檪

@francisschmaltz

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2018

@yevbar Thanks for the PR! We are going to leave the light theme as the default. However, I think that there should be an option at a user level to control what the default is 鈥 right now there is only an option for the current session.

I've CC'd you on an issue where I've suggested this. #434

@sqs

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

Thanks anyway, @yevbar!

@laubzega

This comment has been minimized.

Copy link

commented Nov 21, 2018

The default theme, light gray on white, is a spit in the face of everyone over 50.

@sqs

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

See #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can鈥檛 perform that action at this time.