Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade percy/cli to 1.16 #45171

Merged
merged 1 commit into from Dec 5, 2022
Merged

upgrade percy/cli to 1.16 #45171

merged 1 commit into from Dec 5, 2022

Conversation

burmudar
Copy link
Contributor

@burmudar burmudar commented Dec 5, 2022 •
edited by sourcegraph-bot

Saw randomly in a pipeline percy complaining that we're 10 releases behind ... NOT ANYMORE!

Test plan

main-dry-run https://buildkite.com/sourcegraph/sourcegraph/builds/187051

App preview:

Check out the client app preview documentation to learn more.

@burmudar burmudar requested review from valerybugakov and a team December 5, 2022 14:10
@cla-bot cla-bot bot added the cla-signed label Dec 5, 2022
@burmudar burmudar self-assigned this Dec 5, 2022
jhchabran
jhchabran approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@jhchabran jhchabran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, let's just make sure the frontend folks are aware of the bump.

@sg-e2e-regression-test-bob
Copy link

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (0.00 kb) 0.00% (0.00 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 69a8f33 and 623cd1d or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@sourcegraph-tracking-issue-bot sourcegraph-tracking-issue-bot mentioned this pull request Dec 5, 2022
Closed
38 tasks
@burmudar burmudar enabled auto-merge (squash) December 5, 2022 14:26
@burmudar burmudar merged commit 4107fc8 into main Dec 5, 2022
@burmudar burmudar deleted the wb/upgrade-percy-cli branch December 5, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhchabran jhchabran jhchabran approved these changes

@eseliger eseliger eseliger approved these changes

@valerybugakov valerybugakov Awaiting requested review from valerybugakov

Assignees

@burmudar burmudar

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@burmudar @sg-e2e-regression-test-bob @jhchabran @eseliger