Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style of activated extension toggle #4841

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@vanesa
Copy link
Member

commented Jul 10, 2019

This PR will improve the styling of the activated extension toggle button located in the navigation above the code view (repo header).

Current view of an activated extension toggle.
image

image

Change through this PR:
image

image

vanesa added some commits Jul 9, 2019

@vanesa vanesa requested review from felixfbecker and lguychard as code owners Jul 10, 2019

@felixfbecker
Copy link
Member

left a comment

Appreciate the attempt to improve this, but imo this looks really out of place & worse than before. We don't have gradients anywhere in our UI, it doesn't fit our design. Tbh it doesn't communicate "pressed" or "active" to me either.

@vanesa

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Ok, I was trying out a suggestion I received, and thought it was worth a shot, but I can also just remove the bottom border and stick to the old design. Thank you for your feedback.

@vanesa vanesa closed this Jul 10, 2019

@vanesa vanesa deleted the vo/extension-action-items branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.