Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style of activated extension toggle #4844

Merged
merged 3 commits into from Jul 15, 2019

Conversation

Projects
None yet
2 participants
@vanesa
Copy link
Member

commented Jul 10, 2019

This PR will improve the styling of the activated extension toggle button located in the navigation above the code view (repo header).

Current view of an activated extension toggle:
image

image

Change through this PR:
image

image

@vanesa vanesa requested review from felixfbecker and lguychard as code owners Jul 10, 2019

@@ -56,6 +56,8 @@
}
.action-item--pressed {
background-color: $color-bg-3;
height: 100%;

This comment has been minimized.

Copy link
@felixfbecker

felixfbecker Jul 10, 2019

Member

This is not theme-specific and shouldn't be duplicated.

@@ -65,5 +67,7 @@
}
.action-item--pressed {
background-color: $color-light-bg-3;
height: 100%;
color: $color-light-text-5;

This comment has been minimized.

Copy link
@felixfbecker

felixfbecker Jul 10, 2019

Member

I think something mure blueish would fit better, e.g. $color-light-text-6 or $color-light-text-1

@codecov

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #4844 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4844      +/-   ##
=========================================
- Coverage   48.02%     48%   -0.03%     
=========================================
  Files         728     728              
  Lines       44444   44444              
  Branches     1762    1762              
=========================================
- Hits        21346   21337       -9     
- Misses      21125   21135      +10     
+ Partials     1973    1972       -1
Impacted Files Coverage Δ
cmd/frontend/graphqlbackend/graphqlbackend.go 38.46% <0%> (-6.3%) ⬇️
cmd/frontend/graphqlbackend/repository.go 22.05% <0%> (-0.99%) ⬇️
...d/frontend/internal/authz/bitbucketserver/store.go 80.83% <0%> (+1.19%) ⬆️

@vanesa vanesa requested a review from felixfbecker Jul 14, 2019

@vanesa vanesa merged commit 4e43e5c into master Jul 15, 2019

2 checks passed

buildkite/sourcegraph Build #39820 passed (15 minutes, 2 seconds)
Details
percy/Sourcegraph Visual review automatically approved, no visual changes found.
Details

@vanesa vanesa deleted the vo/extension-action-items-styling branch Jul 15, 2019

keegancsmith added a commit that referenced this pull request Jul 15, 2019

Improve style of activated extension toggle (#4844)
* change color and set height to 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.