Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up overflowing code snippets in docs, fixes 5533 #5534

Merged
merged 4 commits into from Sep 10, 2019

Conversation

@vanesa
Copy link
Member

commented Sep 10, 2019

Add scrolling to note paragraphs that overflow in the docs. Fixes: #5533

Before:

image

After:
image

@vanesa vanesa requested review from ryan-blunden and sqs as code owners Sep 10, 2019

@ryan-blunden

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Any issues with displaying on mobile?

@vanesa

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

I used Chrome mobile preview to test it and it shows no issues:
image

You can just scroll sideways. It's not shown well on the screenshot, but the scrollbar appears while scrolling to the right.

@vanesa

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

Using white-space:pre-wrap instead:
image

@vanesa vanesa force-pushed the vo/docs-container-overflow-fix branch from e22f902 to 8ad859b Sep 10, 2019

@vanesa

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

These changes affect other pages too, which leads to code wrapping pretty early:

image

vs before my changes:
image

@vanesa

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

Improved styling:
image

Mobile:
image

@vanesa vanesa changed the title Add scrolling to paragraphs that overflow in docs, fixes 5533 wrap up overflowing code snippets in docs, fixes 5533 Sep 10, 2019

@vanesa vanesa changed the title wrap up overflowing code snippets in docs, fixes 5533 Wrap up overflowing code snippets in docs, fixes 5533 Sep 10, 2019

@vanesa vanesa merged commit 960366b into master Sep 10, 2019

1 check passed

buildkite/sourcegraph Build #42552 passed (1 minute, 50 seconds)
Details

@vanesa vanesa deleted the vo/docs-container-overflow-fix branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.