Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSIF: fix gitserver args #5941

Merged
merged 1 commit into from Oct 11, 2019
Merged

LSIF: fix gitserver args #5941

merged 1 commit into from Oct 11, 2019

Conversation

@chrismwendt
Copy link
Contributor

chrismwendt commented Oct 10, 2019

Fixes #5940

@chrismwendt chrismwendt requested a review from efritz Oct 10, 2019
@efritz
efritz approved these changes Oct 10, 2019
@chrismwendt chrismwendt force-pushed the lsif-fix-git-args branch from ea7f21b to 89bfc51 Oct 10, 2019
@chrismwendt chrismwendt requested a review from beyang as a code owner Oct 10, 2019
dev/ci/e2e.sh Outdated Show resolved Hide resolved
@chrismwendt chrismwendt force-pushed the lsif-fix-git-args branch from f6bf179 to 89bfc51 Oct 10, 2019
@chrismwendt chrismwendt force-pushed the lsif-fix-git-args branch from 89bfc51 to d48207f Oct 11, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #5941 into master will increase coverage by 2.09%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5941      +/-   ##
==========================================
+ Coverage   37.34%   39.44%   +2.09%     
==========================================
  Files        1154     1153       -1     
  Lines       59843    56647    -3196     
  Branches     5669     5669              
==========================================
- Hits        22348    22343       -5     
+ Misses      35423    32232    -3191     
  Partials     2072     2072
Impacted Files Coverage Δ
lsif/src/commits.ts 42.1% <0%> (ø) ⬆️
migrations/bindata.go
@chrismwendt chrismwendt merged commit 6981238 into master Oct 11, 2019
2 checks passed
2 checks passed
buildkite/sourcegraph Build #44925 passed (11 minutes, 44 seconds)
Details
percy/Sourcegraph Visual review automatically approved, no visual changes found.
Details
@chrismwendt chrismwendt deleted the lsif-fix-git-args branch Oct 11, 2019
@chrismwendt chrismwendt mentioned this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.