LSIF: Replace node-resque with bull #6062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our dependency on node-resque with bull. I made a bad initial choice that caused a bit more friction than necessary when splitting the server and worker.
The latter library is 12x as popular on npm and seems more active in general. This new library has additional features we'll want if we end up sticking with a redis-based queue for work (job progress reporting, priority queues, cron scheduling). This simplifies our setup code a great deal and has working type declarations we don't need to declare ourselves.
I'm doing this now as a scheduled enqueue is the easiest way for us to do work on a schedule (required for RFC 43) while ensuring that (1) doesn't interfere with queries or ongoing conversion, and (2) isn't done by multiple processes.