Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSIF: check gitserver trailers #6549

Merged
merged 6 commits into from Nov 12, 2019
Merged

LSIF: check gitserver trailers #6549

merged 6 commits into from Nov 12, 2019

Conversation

@efritz
Copy link
Contributor

efritz commented Nov 12, 2019

Throw errors when gitserver response contains error trailers.

efritz added 5 commits Nov 12, 2019
@efritz efritz added the lsif label Nov 12, 2019
@efritz efritz changed the title Lsif check gitserver trailers LSIF: check gitserver trailers Nov 12, 2019
@efritz efritz requested a review from chrismwendt Nov 12, 2019
@efritz efritz marked this pull request as ready for review Nov 12, 2019
@efritz efritz requested a review from sourcegraph/code-intel as a code owner Nov 12, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #6549 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #6549      +/-   ##
==========================================
+ Coverage   39.47%   39.47%   +<.01%     
==========================================
  Files        1213     1213              
  Lines       61708    61713       +5     
  Branches     5845     5847       +2     
==========================================
+ Hits        24360    24362       +2     
- Misses      35117    35119       +2     
- Partials     2231     2232       +1
Impacted Files Coverage Δ
lsif/src/shared/models/dump.ts 100% <ø> (ø) ⬆️
lsif/src/worker/processors/update-tips.ts 0% <ø> (ø) ⬆️
lsif/src/server/routes/jobs.ts 0% <ø> (ø) ⬆️
lsif/src/shared/xrepo/commits.ts 91.66% <85.71%> (-1.89%) ⬇️
internal/search/backend/horizontal.go 88.7% <0%> (-1.62%) ⬇️
lsif/src/shared/xrepo/commits.test.ts Show resolved Hide resolved
lsif/src/shared/xrepo/commits.ts Outdated Show resolved Hide resolved
lsif/src/shared/xrepo/commits.ts Outdated Show resolved Hide resolved
@efritz efritz merged commit 67adefc into master Nov 12, 2019
3 checks passed
3 checks passed
build
Details
buildkite/sourcegraph Build #48365 passed (22 minutes, 53 seconds)
Details
percy/Sourcegraph Visual review automatically approved, no visual changes found.
Details
@efritz efritz deleted the lsif-check-gitserver-trailers branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.