Fix status bar updates getting lost (#389)

* Fix status bar updates getting lost

* Add changelog entry

Author: mrnugget

CHANGELOG.md

@@ -18,6 +18,7 @@ All notable changes to `src-cli` are documented in this file.
 ### Fixed
 
 - If `src campaign [validate|apply|preview]` was aborted while it was downloading repository archives it could leave behind partial ZIP files that would produce an error on the next run. This is now fixed by deleting partial files on abort. [#388](https://github.com/sourcegraph/src-cli/pull/388)
+- A bug in `src campaign [apply|preview]` that would cause status bars in the TUI to not update has been fixed. [#389](https://github.com/sourcegraph/src-cli/pull/389)
 
 ### Removed
 

cmd/src/campaign_progress_printer.go

@@ -24,8 +24,10 @@ func newCampaignProgressPrinter(out *output.Output, numParallelism int) *campaig
 }
 
 type campaignProgressPrinter struct {
-	out      *output.Output
-	progress output.ProgressWithStatusBars
+	out *output.Output
+
+	progress      output.ProgressWithStatusBars
+	numStatusBars int
 
 	maxRepoName    int
 	numParallelism int
@@ -67,9 +69,8 @@ func (p *campaignProgressPrinter) PrintStatuses(statuses []*campaigns.TaskStatus
 		return
 	}
 
-	var numStatusBars int
 	if p.progress == nil {
-		numStatusBars = p.initProgressBar(statuses)
+		p.numStatusBars = p.initProgressBar(statuses)
 	}
 
 	newlyCompleted := []*campaigns.TaskStatus{}
@@ -120,7 +121,7 @@ func (p *campaignProgressPrinter) PrintStatuses(statuses []*campaigns.TaskStatus
 			_, ok = p.statusBarRepo[statusBarIndex]
 		}
 
-		if statusBarIndex >= numStatusBars {
+		if statusBarIndex >= p.numStatusBars {
 			// If the only free slot is past the number of status bars we
 			// have, there's a race condition going on where we have more tasks
 			// reporting as "currently executing" than could be executing, most