Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make src-config file hidden and chmod it #37

Closed
P3GLEG opened this issue Jan 14, 2019 · 5 comments
Closed

Make src-config file hidden and chmod it #37

P3GLEG opened this issue Jan 14, 2019 · 5 comments

Comments

@P3GLEG
Copy link

P3GLEG commented Jan 14, 2019

You should ensure that the file is considered "hidden" as a good practice. $HOME/.src-config.json as well as perform a chmod 600 on it. Not the craziest thing in the world but it's weird having it found on my desktop.

@slimsag
Copy link
Member

slimsag commented Jan 14, 2019

Thanks for filing this, I definitely agree! Not sure how we missed this.

@P3GLEG
Copy link
Author

P3GLEG commented Jan 15, 2019

Probably best to put it in ~/.sourcegraph/config. No worries.

@sluongng
Copy link

actually please follow the convention by many other tools and put the config in $HOME/.config/sourcegraph/config.json

@joshuabezaleel
Copy link

Hi everyone, I want to clarify something if I may. cc: @slimsag

So far the only part of the code that I saw mentioned src-config.json is in the main.go's readConfig and is only used when the user supplied their own endpoint and access token and not using the environment variable which then will be overrided by the program's manual assignment if there isn't any argument to the -config flag, right?
Is there any part of the code that saves and output any config to the src-config.json that I miss?

Thank you very much in advance 🙂

@slimsag
Copy link
Member

slimsag commented Jun 3, 2020

@joshuabezaleel that is correct, and no, nothing writes to the file.

@P3GLEG P3GLEG closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants